refactor(estree/tokens): use wildcard import for AST types#19681
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
This was referenced Feb 24, 2026
github-actions
bot
added
the
C-cleanup
This was referenced Feb 24, 2026
Member
Author
This was referenced Feb 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the import statement in crates/oxc_estree_tokens/src/lib.rs to use a wildcard import for AST types from oxc_ast::ast instead of explicitly listing 14 individual type names. This aligns with the well-established convention throughout the oxc codebase where files with extensive AST type usage prefer wildcard imports over long explicit import lists.
Changes:
- Replaced explicit import list of 14 AST types with
use oxc_ast::ast::*
This was referenced Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor. Import AST types with a wildcard
use oxc_ast::ast::*instead of a massive list of types.